Ensure context in Open stays open #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hariso
reviewed
Mar 21, 2022
Comment on lines
+113
to
+114
| ctxOpen := context.Background() | ||
| ctxOpen, a.openCancel = context.WithCancel(ctxOpen) |
There was a problem hiding this comment.
I'm wondering, why don't we simply do ctxOpen, a.openCancel = context.WithCancel(context.Background())?
Or maybe even ctxOpen, a.openCancel = context.WithCancel(ctx)?
There was a problem hiding this comment.
First option won't work unless you declare ctxOpen a line before with var ctxOpen context.Context, not really an improvement IMO.
Second option is essentially what we did before but it had a flaw - the context could be canceled even after Open returns (and it actually happens), so that context is then not suitable for spawning long-running goroutines.
There was a problem hiding this comment.
Thanks! TIL a bit more about multiple short var declarations.: )
hariso
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The context passed to the plugin in
Openshould stay open even after the function returns because the context can be used to spawn background jobs that fetch records.