Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding paramgen #44

Merged
merged 21 commits into from
Jan 5, 2023
Merged

adding paramgen #44

merged 21 commits into from
Jan 5, 2023

Conversation

maha-hajja
Copy link
Contributor

@maha-hajja maha-hajja commented Dec 12, 2022 •
edited by lovromazgon
Loading

Description

parse a Config struct into a map[string]sdk.Parameter and create a file with a function that returns the parameters

Fixes ConduitIO/conduit#696

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same
    update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@maha-hajja maha-hajja requested a review from a team as a code owner December 12, 2022 16:21
lovromazgon
lovromazgon reviewed Dec 14, 2022
View reviewed changes
cmd/paramgen/internal/paramgen.go Outdated Show resolved Hide resolved
cmd/paramgen/internal/paramgen.go Outdated Show resolved Hide resolved
cmd/paramgen/internal/paramgen.go Outdated Show resolved Hide resolved
cmd/paramgen/internal/paramgen.go Outdated Show resolved Hide resolved
cmd/paramgen/main.go Outdated Show resolved Hide resolved
cmd/paramgen/main.go Outdated Show resolved Hide resolved
cmd/paramgen/main.go Outdated Show resolved Hide resolved
cmd/paramgen/main.go Outdated Show resolved Hide resolved
cmd/paramgen/main.go Outdated Show resolved Hide resolved
cmd/paramgen/main.go Outdated Show resolved Hide resolved
hariso
hariso reviewed Dec 19, 2022
View reviewed changes
Copy link
Contributor

@hariso hariso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

cmd/paramgen/internal/paramgen.go Outdated Show resolved Hide resolved
cmd/paramgen/internal/paramgen.go Show resolved Hide resolved
cmd/paramgen/internal/paramgen.go Outdated Show resolved Hide resolved
cmd/paramgen/internal/paramgen.go Outdated Show resolved Hide resolved
cmd/paramgen/internal/paramgen.go Outdated Show resolved Hide resolved
cmd/paramgen/internal/testdata/basic/specs.go Show resolved Hide resolved
cmd/paramgen/internal/testdata/complex/specs_test.go Outdated Show resolved Hide resolved
cmd/paramgen/internal/paramgen_test.go Show resolved Hide resolved
hariso
hariso approved these changes Dec 19, 2022
View reviewed changes
Copy link
Contributor

@hariso hariso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀

@maha-hajja maha-hajja merged commit 62b54dd into main Jan 5, 2023
@maha-hajja maha-hajja deleted the maha/paramgen branch January 5, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovromazgon lovromazgon lovromazgon left review comments

@hariso hariso hariso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Builtin Config Validations: Generate connector configurations from a Go struct
3 participants
@maha-hajja @hariso @lovromazgon