feature(ui): update to ember 5.7 and latest dependencies (#1483)

* feat: ember 5.7 * upgrade ember-changeset * update more dependencies * upgrade all minors * upgrade ember-cli-babel * upgrade ember-basic-dropdown * upgrade test packages * upgrade ember-cli-flash * upgrade ember-page-title * upgrade qunit-dom * upgrade prettier * undo this requires more updates to eslint * upgrade postcss-import * upgrade ember-truth-helpers * upgrade ember-source * upgrade ember-resolver * Update yarn.lock * redirect home * back to 7.2.1 otherwise, it requires more work to fix styles * upgrade linting and other pkgs depend on it * update minor pkgs * upgrade stylelint-prettier * upgrade eslint-plugin-n * leave a comment
ConduitIO · Apr 15, 2024 · 98ad6b3 · 98ad6b3
1 parent af6a8b7
commit 98ad6b3
Show file tree

Hide file tree

Showing 48 changed files with 2,873 additions and 1,060 deletions.
diff --git a/ui/.eslintignore b/ui/.eslintignore
@@ -1,9 +1,11 @@
 # unconventional js
 /blueprints/*/files/
+/blueprints/*/index.js
 /vendor/
 
 # compiled output
 /dist/
+/dist-prod/
 /tmp/
 
 # dependencies
@@ -14,12 +16,10 @@
 /coverage/
 !.*
 .*/
-.eslintcache
 
 # ember-try
 /.node_modules.ember-try/
 /bower.json.ember-try
 /npm-shrinkwrap.json.ember-try
 /package.json.ember-try
 /package-lock.json.ember-try
-/yarn.lock.ember-try
diff --git a/ui/.eslintrc.js b/ui/.eslintrc.js
@@ -2,12 +2,15 @@
 
 module.exports = {
   root: true,
-  parser: 'babel-eslint',
+  parser: '@babel/eslint-parser',
   parserOptions: {
-    ecmaVersion: 2018,
+    ecmaVersion: 'latest',
     sourceType: 'module',
-    ecmaFeatures: {
-      legacyDecorators: true,
+    requireConfigFile: false,
+    babelOptions: {
+      plugins: [
+        ['@babel/plugin-proposal-decorators', { decoratorsBeforeExport: true }],
+      ],
     },
   },
   plugins: ['ember'],
@@ -18,14 +21,23 @@ module.exports = {
   ],
   env: {
     browser: true,
+    node: true,
+  },
+  rules: {
+    // this can be removed once the following is fixed
+    // https://github.com/mysticatea/eslint-plugin-node/issues/77
+    'node/no-unpublished-require': 'off',
+
+    // TODO: remove this and fix issues raised
+    'ember/no-runloop': 'off',
   },
-  rules: {},
   overrides: [
     // node files
     {
       files: [
         './.eslintrc.js',
         './.prettierrc.js',
+        './.stylelintrc.js',
         './.template-lintrc.js',
         './ember-cli-build.js',
         './testem.js',
@@ -41,13 +53,7 @@ module.exports = {
         browser: false,
         node: true,
       },
-      plugins: ['node'],
-      extends: ['plugin:node/recommended'],
-      rules: {
-        // this can be removed once the following is fixed
-        // https://github.com/mysticatea/eslint-plugin-node/issues/77
-        'node/no-unpublished-require': 'off',
-      },
+      extends: ['plugin:n/recommended'],
     },
     {
       // test files

diff --git a/ui/.prettierignore b/ui/.prettierignore
@@ -1,25 +1,21 @@
+/blueprints/*/index.js
+/blueprints/*/files/
+/blueprints/*/index.js
+
 # unconventional js
 /blueprints/*/files/
-/vendor/
 
 # compiled output
 /dist/
-/tmp/
-
-# dependencies
-/bower_components/
-/node_modules/
 
 # misc
 /coverage/
 !.*
-.eslintcache
-.lint-todo/
+.*/
 
 # ember-try
 /.node_modules.ember-try/
 /bower.json.ember-try
 /npm-shrinkwrap.json.ember-try
 /package.json.ember-try
 /package-lock.json.ember-try
-/yarn.lock.ember-try
diff --git a/ui/.stylelintignore b/ui/.stylelintignore
@@ -0,0 +1,10 @@
+# unconventional files
+/blueprints/*/files/
+/coverage/*
+
+# compiled output
+/dist/
+/dist-prod/
+
+# addons
+/.node_modules.ember-try/
diff --git a/ui/.stylelintrc.js b/ui/.stylelintrc.js
@@ -0,0 +1,13 @@
+'use strict';
+
+module.exports = {
+  extends: ['stylelint-config-standard', 'stylelint-prettier/recommended'],
+  rules: {
+    'at-rule-no-unknown': [
+      true,
+      {
+        ignoreAtRules: ['/tailwind/'],
+      },
+    ],
+  },
+};
diff --git a/ui/app/adapters/application.js b/ui/app/adapters/application.js
@@ -22,15 +22,15 @@ export default class ApplicationAdapter extends RESTAdapter {
       return payload;
     } else if (this.isInvalid(status, headers, payload)) {
       return new InvalidError(
-        typeof payload === 'object' ? payload.details : undefined
+        typeof payload === 'object' ? payload.details : undefined,
       );
     }
 
     const handledResponse = super.handleResponse(
       status,
       headers,
       payload,
-      requestData
+      requestData,
     );
 
     if (handledResponse.isAdapterError) {

diff --git a/ui/app/components/pipeline-editor.js b/ui/app/components/pipeline-editor.js
@@ -109,7 +109,7 @@ export default class PipelineEditorComponent extends Component {
             'connectorPlugin',
             'pipeline',
           ],
-        }
+        },
       );
     });
   }
@@ -179,7 +179,7 @@ export default class PipelineEditorComponent extends Component {
           'connectorPlugin',
           'pipeline',
         ],
-      }
+      },
     );
     this.isShowingNewConnectorModal = true;
   }
@@ -249,7 +249,7 @@ export default class PipelineEditorComponent extends Component {
     await connector.data.destroyRecord();
 
     this.wrappedConnectors.removeObject(
-      this.wrappedConnectors.findBy('id', connectorId)
+      this.wrappedConnectors.findBy('id', connectorId),
     );
     this.pipelineNodeManager.regeneratePaths();
     this.selectNode(null);
@@ -263,7 +263,7 @@ export default class PipelineEditorComponent extends Component {
       function () {
         this.selectedNode = node;
       },
-      10
+      10,
     );
 
     if (event) {

diff --git a/ui/app/components/pipeline-editor/config-field.js b/ui/app/components/pipeline-editor/config-field.js
@@ -70,7 +70,7 @@ export default class PipelineEditorConfigFieldComponent extends Component {
   generateSelectOptions() {
     const inclusionValidation = this.args.field.rawValidations.findBy(
       'type',
-      'TYPE_INCLUSION'
+      'TYPE_INCLUSION',
     );
     return inclusionValidation.value.split(',').map((item) => {
       return {

diff --git a/ui/app/components/pipeline-editor/connector-modal.js b/ui/app/components/pipeline-editor/connector-modal.js
@@ -51,7 +51,7 @@ export default class PipelineEditorNewConnectorModal extends Component {
     if (this.isEditing) {
       this.blueprintFields = generateBlueprintFields(
         this.connector.plugin.getParams(this.connector.type),
-        this.connector
+        this.connector,
       );
     } else {
       this.blueprintFields = [];
@@ -149,7 +149,7 @@ export default class PipelineEditorNewConnectorModal extends Component {
       this.connector.validate();
       this.blueprintFields = generateBlueprintFields(
         plugin.getParams(this.connector.type),
-        this.connector
+        this.connector,
       );
     }
     this.isShowingRequiredTab = true;
@@ -162,7 +162,7 @@ export default class PipelineEditorNewConnectorModal extends Component {
     if (fieldChangeset.isValid) {
       this.connector.set(
         `config.settings.${fieldChangeset.id}`,
-        fieldChangeset.value
+        fieldChangeset.value,
       );
     } else {
       this.connector.set(`config.settings.${fieldChangeset.id}`, undefined);

diff --git a/ui/app/components/pipeline-editor/connector-slide-panel.js b/ui/app/components/pipeline-editor/connector-slide-panel.js
@@ -46,7 +46,7 @@ export default class PipelineEditorConnectorSlidePanel extends Component {
         ConnectorTransformValidations,
         {
           changesetKeys: ['type', 'config', 'parent'],
-        }
+        },
       );
     });
   }
@@ -68,7 +68,7 @@ export default class PipelineEditorConnectorSlidePanel extends Component {
       ConnectorTransformValidations,
       {
         changesetKeys: ['type', 'config', 'parent', 'transform'],
-      }
+      },
     );
 
     this.isShowingNewTransformPanel = true;
@@ -136,7 +136,7 @@ export default class PipelineEditorConnectorSlidePanel extends Component {
       ConnectorTransformValidations,
       {
         changesetKeys: ['type', 'config', 'parent', 'transform'],
-      }
+      },
     );
 
     this.addTransform(changeset);

diff --git a/ui/app/components/pipeline-editor/connector-slide-panel/transform-panel.js b/ui/app/components/pipeline-editor/connector-slide-panel/transform-panel.js
@@ -19,12 +19,12 @@ export default class PipelineEditorConnectorSlidePanelTransformPanel extends Com
     this.connectorTransform = this.args.connectorTransform;
     this.blueprintFields = generateBlueprintFields(
       this.connectorTransform.data.transform.blueprint,
-      this.connectorTransform
+      this.connectorTransform,
     );
 
     this.selectedTransformOnOption = this.transformOnOptions.findBy(
       'value',
-      this.connectorTransform.type
+      this.connectorTransform.type,
     );
   }
 
@@ -52,7 +52,7 @@ export default class PipelineEditorConnectorSlidePanelTransformPanel extends Com
     this.connectorTransform.type = option.value;
     this.selectedTransformOnOption = this.transformOnOptions.findBy(
       'value',
-      option.value
+      option.value,
     );
   }
 
@@ -63,7 +63,7 @@ export default class PipelineEditorConnectorSlidePanelTransformPanel extends Com
     if (fieldChangeset.isValid) {
       this.connectorTransform.set(
         `config.settings.${fieldChangeset.id}`,
-        fieldChangeset.value
+        fieldChangeset.value,
       );
     } else {
       this.connectorTransform.set(`config.${fieldChangeset.id}`, undefined);

diff --git a/ui/app/controllers/pipeline.js b/ui/app/controllers/pipeline.js
@@ -24,7 +24,7 @@ export default class PipelineController extends Controller {
     pipeline.onPipelineEvent(
       'onPipelineDegraded',
       this,
-      this._handlePipelineRunError
+      this._handlePipelineRunError,
     );
     pipeline.pollPipeline.perform();
   }

diff --git a/ui/app/modifiers/scroll-bottom.js b/ui/app/modifiers/scroll-bottom.js
@@ -7,5 +7,5 @@ export default modifier(
       element.scrollTop = 0;
     };
   },
-  { eager: false }
+  { eager: false },
 );
diff --git a/ui/app/modifiers/zoom-zoom.js b/ui/app/modifiers/zoom-zoom.js
@@ -25,5 +25,5 @@ export default modifier(
       select('#editor-container').on('.zoom', null);
     };
   },
-  { eager: false }
+  { eager: false },
 );
diff --git a/ui/app/router.js b/ui/app/router.js
@@ -17,7 +17,7 @@ Router.map(function () {
       function () {
         // => this.route('index');
         this.route('settings');
-      }
+      },
     );
   });
 

diff --git a/ui/app/routes/home.js b/ui/app/routes/home.js
@@ -1,7 +1,9 @@
+import { inject as service } from '@ember/service';
 import Route from '@ember/routing/route';
 
 export default class HomeRoute extends Route {
+  @service('router') router;
   redirect() {
-    this.transitionTo('pipelines');
+    this.router.transitionTo('pipelines');
   }
 }
diff --git a/ui/app/routes/pipeline.js b/ui/app/routes/pipeline.js
@@ -26,7 +26,7 @@ export default class PipelineRoute extends Route {
         PipelineValidations,
         {
           changesetKeys: ['name', 'description'],
-        }
+        },
       );
       pipeline.validate();
     } else {

diff --git a/ui/app/routes/pipeline/settings.js b/ui/app/routes/pipeline/settings.js
@@ -21,7 +21,7 @@ export default class PipelineSettingsRoute extends Route {
       PipelineValidations,
       {
         changesetKeys: ['name', 'description', 'tags'],
-      }
+      },
     );
   }
 

diff --git a/ui/app/serializers/connector.js b/ui/app/serializers/connector.js
@@ -14,15 +14,15 @@ export default class ConnectorSerializer extends ApplicationSerializer {
     const configSettings = super._replaceKeys(
       snapshot.record.config.settings,
       '@@',
-      '.'
+      '.',
     );
 
     snapshot.record.config.settings = configSettings;
 
     return {
       config: snapshot.record.config,
       type: Object.keys(CONNECTOR_TYPE_MAP).find(
-        (key) => CONNECTOR_TYPE_MAP[key] === snapshot.record.type
+        (key) => CONNECTOR_TYPE_MAP[key] === snapshot.record.type,
       ),
       plugin: snapshot.record.plugin.get('id'),
       pipeline_id: snapshot.record.pipeline.get('id'),
@@ -33,7 +33,7 @@ export default class ConnectorSerializer extends ApplicationSerializer {
     const hasOnlyType = /^(any|builtin|standalone):[\w-]+$/.test(matchTo);
     const hasOnlyVersion = /^[\w-]+@v\S+$/.test(matchTo);
     const hasTypeAndVersion = /^(any|builtin|standalone):[\w-]+@v\S+$/.test(
-      matchTo
+      matchTo,
     );
 
     let pluginName = matchTo;
@@ -126,7 +126,7 @@ export default class ConnectorSerializer extends ApplicationSerializer {
       const configSettings = super._replaceKeys(
         hash.config?.settings,
         '.',
-        '@@'
+        '@@',
       );
       hash.config.settings = configSettings;
     }

diff --git a/ui/app/serializers/plugin.js b/ui/app/serializers/plugin.js
@@ -8,7 +8,7 @@ export default class ConnectorPluginSerializer extends ApplicationSerializer {
     hash.destinationParams = super._replaceKeys(
       hash.destinationParams,
       '.',
-      '@@'
+      '@@',
     );
 
     return super.normalize(typeClass, hash);