Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(ember): upgrade to latest LTS (4.8.x) #1011

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Conversation

jayjayjpg
Copy link
Contributor

Description of change

Closes #1005
Part of https://github.com/meroxa/product/issues/749

With this change, we're upgrading conduit/ui from ember@4.0.1 to the latest LTS ember@4.8.x. This way, conduit/ui can also upgrade to latest security patches provided to Ember until December 2023.

This upgrade includes several minor version bumps in order to benefit from a bug fix in @ember/data that just landed in the 4.9 release. The related bug prevented us from upgrading beyond ember@4.7 due to an error in identifying new data records wrapped with ember-changeset correctly (Assertion Failed: Expected to receive a stable Identifier to subscribe to).

In addition, this upgrade includes:

Resolutions

The following changes were made to upgrade:

  • run ember-cli-update --to 4.8
  • re-run rm -rf node_modules && yarn to remove the existing npm packages and start a fresh install
  • run ember t -s to start the test suite and see errors related to the upgrade
  • work through all of the errors mentioned below and re-build / re-run the test suite after each resolution to verify
  • once tests pass, shut down the test server and re-run sudo yarn start to verify the changes locally at https://dev.meroxa.io

Build error @babel/template placeholder "SAMPLE_FEATURE_FLAG": Expected string substitution

  • you should see the @embroider/macros error in your terminal window (Build failure)
  • open the log file mentioned in the error output
    --> you should see the error stack trace pointing to the node_modules and you should see a reference to ember-cli-mirage
  • pin resolutions for the following packages as follows in package.json:
"resolutions": {
 // ...
     "miragejs": "~0.1.47",
    "@embroider/macros": "^1.10.0",
    "@embroider/util": "^1.10.0",
    "ember-cli-babel": "^7.26.11",
    "ember-modifier": "^3.2.7"
 // ...
 }
  • re-run rm -rf node_modules && yarn to remove the existing npm packages and start a fresh install

Blockers before merging

  • tests

How to verify?

  • checkout the feature branch and run the app locally
  • browse around
  • -> the app should work as expected and no errors should be thrown

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@jayjayjpg jayjayjpg requested a review from a team as a code owner April 26, 2023 08:57
@github-actions
Copy link

UI test coverage: 79.31%

🚨 No before coverage could be loaded

@github-actions
Copy link

UI test coverage: 79.31%

🚨 No before coverage could be loaded

@github-actions
Copy link

UI test coverage: 79.31%

🚨 No before coverage could be loaded

@jayjayjpg jayjayjpg merged commit 096656f into main Apr 26, 2023
7 checks passed
@jayjayjpg jayjayjpg deleted the jj/ember-upgrade branch April 26, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ember Upgrade for conduit-ui
2 participants