-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(connectors): add section about adding built-in connectors #1021
Conversation
4d0eb20
to
1e51be3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking the initiative with these super helpful instructions! lovely work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your addition @jayjayjpg! The issue is that this document is supposed to be reworked altogether and moved to conduit.io (#1015). How important is it to get this in now?
Also, I'm thinking if it would make sense to have a separate page on conduit.io that just addresses compiling your own Conduit binary with custom built-in connectors?
@lovromazgon I like the idea of having a dedicated page for this on conduit.io, too! Would it make sense to get this change in just for further reference until the documentation rework is completed and to add another page to the hosted conduit docs in a follow up? This way, we'd already have some minimal documentation on this process for now in case the question about built-in connectors comes up again in the near future and we would still be able to dedicate more time on documenting this properly on conduit.io for the general audience What do you and @simonl2002 think? |
@jayjayjpg yes, lets separate this work from the work to add information to the conduit site. |
1e51be3
to
c4306ca
Compare
c4306ca
to
0993b5f
Compare
@maha-hajja @lovromazgon Thank you for all the feedback! I just updated the branch with your suggestions, let me know what you think! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More or less just nitpicks, all-in-all looks good 👍
Co-authored-by: Lovro Mažgon <lovro.mazgon@gmail.com>
Co-authored-by: Lovro Mažgon <lovro.mazgon@gmail.com>
Co-authored-by: Lovro Mažgon <lovro.mazgon@gmail.com>
Co-authored-by: Lovro Mažgon <lovro.mazgon@gmail.com>
06cb89c
to
8e2c62b
Compare
8e2c62b
to
eafb4d8
Compare
Description
Following our discussion on Slack, this is adding additional documentation around built-in connectors and how to add them to custom binaries.
Quick checks:
Preview
Preview Link