Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't trigger lifecycle events for DLQ connectors #1025

Merged
merged 1 commit into from
May 5, 2023
Merged

Don't trigger lifecycle events for DLQ connectors #1025

merged 1 commit into from
May 5, 2023

Conversation

lovromazgon
Copy link
Member

Description

This disables lifecycle events for DLQ connectors.

Hotfix for #1016

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@lovromazgon lovromazgon requested a review from a team as a code owner May 4, 2023 17:20
maha-hajja
maha-hajja approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@maha-hajja maha-hajja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lovromazgon lovromazgon merged commit 323cd0f into main May 5, 2023
3 checks passed
@lovromazgon lovromazgon deleted the lovro/dlq-hotfix branch May 5, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maha-hajja maha-hajja maha-hajja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lovromazgon @maha-hajja