Remove .dockerignore #1036
Merged
Remove .dockerignore #1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a followup to #1035. That PR made the situation better, but did not fix the issue entirely. The version is now reported, but has the suffix
-dirty, most likely because some files are not added to the docker context.This PR removes
.dockerignoreentirely. This will mean that all files in the repo are imported into the docker context and git should then report the correct version.A fresh repo clone contains 35MB of data,
.dockerignorecurrently ignores ~2.5MB of files, so the context size will increase by 7%. I think we can live with that.Fixes (hopefully) #895.