Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(actions): match node version for ember #1066

Merged
merged 1 commit into from
Jun 6, 2023
Merged

build(actions): match node version for ember #1066

merged 1 commit into from
Jun 6, 2023

Conversation

jmar910
Copy link
Member

@jmar910 jmar910 commented Jun 6, 2023

Description

Make sure we are using node 16 in gh actions

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@jmar910 jmar910 requested a review from a team as a code owner June 6, 2023 16:08
@jmar910 jmar910 self-assigned this Jun 6, 2023
jayjayjpg
jayjayjpg approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@jayjayjpg jayjayjpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads great, thank you for another quick upgrade! ✨

@jmar910 jmar910 merged commit fdb0b0e into main Jun 6, 2023
3 checks passed
@jmar910 jmar910 deleted the james/gh-runner-node-v branch June 6, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayjayjpg jayjayjpg jayjayjpg approved these changes

Assignees

@jmar910 jmar910

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jmar910 @jayjayjpg