Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Debian Bullseye in Dockerfile #1108

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Use Debian Bullseye in Dockerfile #1108

merged 1 commit into from
Jul 10, 2023

Conversation

hariso
Copy link
Contributor

@hariso hariso commented Jul 10, 2023

Description

Fixes #1107. I didn't find a pressing need to use debian:bookworm so I believe it's fine that we use debian:bullseye.

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
    • Tested manually.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@hariso hariso requested a review from a team as a code owner July 10, 2023 13:19
lovromazgon
lovromazgon approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@lovromazgon lovromazgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work debugging this 👍

@hariso hariso merged commit 1cf327c into main Jul 10, 2023
3 checks passed
@hariso hariso deleted the haris/fix-docker-builds branch July 10, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovromazgon lovromazgon lovromazgon approved these changes

@maha-hajja maha-hajja maha-hajja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docker builds failing
3 participants
@hariso @lovromazgon @maha-hajja