BP: List processor plugins in API #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hariso
reviewed
Mar 6, 2024
| } | ||
|
|
||
| func ConnectorPluginParamValidations(in []connector.Validation) []*configv1.Validation { | ||
| // we need an empty slice here so that the returned JSON would be "validations":[] instead of "validations":null |
There was a problem hiding this comment.
You shouldn't, this will go away once we move to conduit-commons in conduit and the connector SDK 🙂
hariso
approved these changes
Mar 6, 2024
4 tasks
lovromazgon
added a commit
that referenced
this pull request
Mar 7, 2024
* Refactor pkg/plugin and isolate connector plugin (#1302) * refactor pkg/plugin and isolate connector plugin * fix imports * fix tests * fix import * change registry to connectorRegistry --------- Co-authored-by: Haris Osmanagić <haris@meroxa.io> * BP: WASM: Load available WASM processors (#1322) Co-authored-by: Maha Hajja <82542081+maha-hajja@users.noreply.github.com> --------- Co-authored-by: Lovro Mažgon <lovro.mazgon@gmail.com> Co-authored-by: Maha Hajja <82542081+maha-hajja@users.noreply.github.com> * Refactor pkg/plugin and isolate connector plugin (#1302) * refactor pkg/plugin and isolate connector plugin * fix imports * fix tests * fix import * change registry to connectorRegistry --------- Co-authored-by: Haris Osmanagić <haris@meroxa.io> * BP: WASM: Load available WASM processors (#1322) Co-authored-by: Maha Hajja <82542081+maha-hajja@users.noreply.github.com> --------- Co-authored-by: Lovro Mažgon <lovro.mazgon@gmail.com> Co-authored-by: Maha Hajja <82542081+maha-hajja@users.noreply.github.com> * Refactor processor service, processor and node (#1354) * linter * Run processor examples, gather specifications (#1384) * update processor-sdk, use config parameter from conduit-commons * add unified diff lib * add utilities for running processor examples and collecting specifications * update diff readme * fix markdown linter error * fix liter errors * update processor-sdk * fix race condition in test * BP: Display processor example raw data as string (#1397) * display raw data in processor examples as string * ensure examples are formatted the same way in processors.json * BP: add builtin processor part#1 (#1371) * add processors field.set & field.subset.exclude * delete extra test * fix tests * add field.rename processor * add exclusion validation to field.rename processor * refactor + fix error return in Process method * add field.convert processor * add filter processor * only structured data * address reviews part1 * use paramgen, update Configure method, update tests * evaluate value for processor setField * use a slice of referenceResolvers for processors with multiple fields params * do not allow .Position to be set in setField processor * update setField test, add non existent field test * use the new Rename() method from referenceResolver * address reviews * address reviews2 * fix renameField bug + add New() method to each processor * linter fix * add processor examples * processor json * Update pkg/plugin/processor/builtin/convertField.go Co-authored-by: Lovro Mažgon <lovro.mazgon@gmail.com> * address reviews * setFeild example * setFeild example * make generate * fix paramgen regex * generate * fix regex * add paramgen to tools --------- Co-authored-by: Lovro Mažgon <lovro.mazgon@gmail.com> * BP: Add unwrap.debezium (#1393) * BP: Add unwrap.kafkaconnect (#1395) * BP: Add webhook.http (#1382) * BP: Add unwrap.opencdc (#1387) * BP: Add encode.avro (#1401) * updated docs, regenerate * config * first pass * downgrade lib * processing * example * fix config parsing * regenerate * fix config * regenerate, tests * linter, move to opencdc * add test certs * config refactor, tests * more tests * linter * Regenerate * fix linter * git diff * git diff * regenerate * avro examples * run schema registry in examples on port 54321 * fix linter error * rename processor * fix schema registry integration test * don't run avro examples in integration tests --------- Co-authored-by: Lovro Mažgon <lovro.mazgon@gmail.com> * BP: Add custom.javascript (#1374) * add json.decode processor (#1405) * add json.decode processor * make generate * processors * address reviews * make generate * add support for decoding JSON types other than map * make generate * address review comments --------- Co-authored-by: Lovro Mažgon <lovro.mazgon@gmail.com> * BP: List processor plugins in API (#1406) * update proto API definitions * fix proto linter warnings * deprecate ListPlugins * implement plugin list endpoint * processor plugin orchestrator * move plugin endpoints under connector and processor service * BP: add avro.decode (#1410) Co-authored-by: Lovro Mažgon <lovro.mazgon@gmail.com> * avro.decode example, remove base64 decoding --------- Co-authored-by: Lovro Mažgon <lovro.mazgon@gmail.com> * BP: Base64 decode / encode processors (#1412) * encode * base64 decode * organize imports * add encodeJson processor (#1413) * encode json processor * delete forgotten test * address reviews * linter fix * add processor examples * don't encode nil, output string --------- Co-authored-by: Lovro Mažgon <lovro.mazgon@gmail.com> * Builtin processors refactoring, housekeeping (#1402) * refactor builtin processors, generate specs into separate files * move processors into folder impl * go mod tidy * add example summaries * add example summaries * fix name of avro.decode processor * add example summaries * regenerate specs * update default registry * update default registry: fix tests, linter, regenerate * dep upgrades * refactorings * move json encode processor to impl/json * rename field.subset.exclude to field.exclude * rename constructor for unwrap.debezium processor * regenerate specs * dep downgrades --------- Co-authored-by: Haris Osmanagic <haris@meroxa.io> * fix linter * BP: call the conditional execution methods in the processors (#1411) * init * simplify * fix evaluation * add support for batches in runnable processor * batch test in runnable processor * optimize case when all records are passed through in a processor * make sure remaining records are copied over * fix len check * make sure processor doesn't return more records --------- Co-authored-by: Lovro Mažgon <lovro.mazgon@gmail.com> * update examples and specs * disable goconst in processors (docs are repetitive) * upgrade processor sdk * add log when loading wasm processors, more docs updates --------- Co-authored-by: Haris Osmanagić <haris@meroxa.io> Co-authored-by: Maha Hajja <82542081+maha-hajja@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This deprecates the gRPC endpoint
PluginService.ListPlugins(GET /v1/plugins) and instead introduces two separate endpoints:ListConnectorPlugins(GET /v1/plugins/connectors)ListProcessorPlugins(GET /v1/plugins/processors)The old endpoint still exists, to not break existing clients (for example the UI).
Fixes #1292
Quick checks: