Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scripts for bumping versions #995

Merged
merged 6 commits into from
Apr 14, 2023
Merged

Scripts for bumping versions #995

merged 6 commits into from
Apr 14, 2023

Conversation

hariso
Copy link
Contributor

@hariso hariso commented Apr 11, 2023 •
edited

Description

Automates:

  1. the bumping of the SDK version in the built-in connectors
  2. the bumping of the versions of built-in connectors in Conduit itself

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@hariso hariso marked this pull request as ready for review April 11, 2023 15:08
@hariso hariso requested a review from a team as a code owner April 11, 2023 15:08
maha-hajja
maha-hajja reviewed Apr 12, 2023
View reviewed changes
Copy link
Contributor

@maha-hajja maha-hajja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these will definitely make our lives easier! thanks for taking the time on this

scripts/bump-builtin-connectors.sh Outdated Show resolved Hide resolved
@hariso hariso requested a review from maha-hajja April 13, 2023 03:48
maha-hajja
maha-hajja approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@maha-hajja maha-hajja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

scripts/bump-sdk-in-connectors.sh Show resolved Hide resolved
@lovromazgon lovromazgon merged commit a1d1f41 into main Apr 14, 2023
3 checks passed
@lovromazgon lovromazgon deleted the haris/bump-scripts branch April 14, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovromazgon lovromazgon lovromazgon left review comments

@maha-hajja maha-hajja maha-hajja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hariso @lovromazgon @maha-hajja