fix(authentication): apple strategy using provider

instead of conduit client id fix(authentication): native login using wrong clientid
ConduitPlatform · Jan 11, 2024 · 8f379b6 · 8f379b6
1 parent 470798e
commit 8f379b6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/modules/authentication/src/handlers/oauth2/OAuth2.ts b/modules/authentication/src/handlers/oauth2/OAuth2.ts
@@ -191,7 +191,7 @@ export abstract class OAuth2<T, S extends OAuth2Settings>
 
     return TokenProvider.getInstance().provideUserTokens({
       user,
-      clientId: this.settings.clientId,
+      clientId: call.request.context.clientId,
       config,
     });
   }

diff --git a/modules/authentication/src/handlers/oauth2/apple/apple.ts b/modules/authentication/src/handlers/oauth2/apple/apple.ts
@@ -27,7 +27,6 @@ import {
   ConfigController,
   RoutingManager,
 } from '@conduitplatform/module-tools';
-import { isNil } from 'lodash';
 import { AuthUtils } from '../../../utils';
 
 export class AppleHandlers extends OAuth2<AppleUser, AppleOAuth2Settings> {
@@ -139,10 +138,12 @@ export class AppleHandlers extends OAuth2<AppleUser, AppleOAuth2Settings> {
     const redirectUri =
       AuthUtils.validateRedirectUri(stateToken.data.customRedirectUri) ??
       this.settings.finalRedirect;
+    const conduitClientId = stateToken.data.clientId;
+
     return TokenProvider.getInstance()!.provideUserTokens(
       {
         user,
-        clientId,
+        clientId: conduitClientId,
         config,
       },
       redirectUri,