Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(email,authentication,forms): email activation bus event pub/sub #105

Merged
merged 1 commit into from
Apr 1, 2022

Conversation

kon14
Copy link
Contributor

@kon14 kon14 commented Mar 31, 2022

Fixes #104.

Authentication's bus subscription to email:status:onConfig no longer triggers its own reconfiguration exclusively on an active Email configuration update, but in any Email config event.
This change is intentional and should pave the way towards Authentication being capable of handling email service going down (due to provider issues for instance as we don't support explicit module deactivation) once we actually introduce any such checks in Email.

Notice: Authentication no longer assumes Email service is available on local auth after #103.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx, where "xxx" is the issue number)

@kkopanidis kkopanidis merged commit 7ea82f8 into main Apr 1, 2022
@kkopanidis kkopanidis deleted the fix-email-bus branch April 1, 2022 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Email activation bus pub/sub events not working
2 participants