-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(authentication,config): remove Authentication's dependency on Email for unverified local email auth strategies #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On second thought, going to improve on this prior to merge in the following ways:
|
BREAKING CHANGE: POST /admin/authentication/users body param 'identifier' -> 'email'
10 tasks
This PR also introduces proper character validation for user email fields. |
sdimitris
approved these changes
Apr 4, 2022
Michael-Vol
approved these changes
Apr 4, 2022
kkopanidis
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR greatly improves the experience of setting up a new deployment from scratch by removing Authentication`s Email dependency on a fresh database. Fixes #99.
This change is going to be extremely useful for newcomers trying out Conduit for the first time as the docs can now be simplified in that regard.
As far as backend contributors are concerned, it's also going to significantly reduce the amount of time spent on submitting configuration requests just to get an active local auth post db wipes.
The Authentication's configuration schema's local section has also been slightly altered so as to keep things clean and structured.
Check out the relevant changes below:
Routes depending on Email now only get registered if Email is online (previously threw 404 in handlers instead).
Auth reregisters its routes on email activation.
This is currently broken due to #104, but I'm opening a follow-up PR to address this so as to keep this one clean.
Also fixed VerifyChangePassword route being registered without 2FA.
Old:
New:
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change?
Local authentication identifier has been deprecated:
POST /admin/authentication/users body param 'identifier' -> 'email'
The PR fulfills these requirements:
main
branchIf adding a new feature, the PR's description includes: