Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(commons,config,core,router,admin,security): config update #131

Merged
merged 1 commit into from
May 3, 2022

Conversation

kon14
Copy link
Contributor

@kon14 kon14 commented May 3, 2022

Adds setConfig() to configurable core module abstract classes and interfaces in commons sdk.
Fixes set/getConfig() not working for admin, router.
Adds set/getConfig() for security.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other (please describe)

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the PR's description (e.g. fix #xxx, where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature

@kon14 kon14 requested review from sdimitris and kkopanidis May 3, 2022 12:36
@sdimitris sdimitris marked this pull request as ready for review May 3, 2022 12:37
@kkopanidis kkopanidis merged commit 3f224b4 into main May 3, 2022
@kkopanidis kkopanidis deleted the core-update-config branch May 3, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants