Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): add file uploads by url instead of base64 #550

Merged
merged 2 commits into from
Mar 21, 2023

Conversation

kkopanidis
Copy link
Contributor

fix(storage): add consistent expiry of signed urls

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other (please describe)

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the PR's description (e.g. fix #xxx, where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature

Other information:

@kkopanidis
Copy link
Contributor Author

Missing to add updateFile by url as well

kon14
kon14 previously requested changes Mar 9, 2023
modules/storage/src/providers/azure/index.ts Outdated Show resolved Hide resolved
@kkopanidis kkopanidis merged commit 8b32a8e into main Mar 21, 2023
@kkopanidis kkopanidis deleted the storage-upload branch March 21, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants