Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage)!: update file by url endpoints #552

Merged
merged 9 commits into from
Mar 21, 2023

Conversation

ChrisPdgn
Copy link
Contributor

@ChrisPdgn ChrisPdgn commented Mar 9, 2023

All "move" and "rename" provider functions are removed as most providers don't support a move operation.
With that stated, the updateFile endpoints now require the file data too, either by passing it as a body param or by uploading the file by url
Fix: Add checks in places where filename is given, in case folder name is '/'

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other (please describe)

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the PR's description (e.g. fix #xxx, where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature

@ChrisPdgn ChrisPdgn marked this pull request as ready for review March 9, 2023 15:52
@ChrisPdgn ChrisPdgn marked this pull request as draft March 9, 2023 16:04
@ChrisPdgn ChrisPdgn changed the title feat(storage): update file by url endpoints feat(storage)!: update file by url endpoints Mar 10, 2023
@ChrisPdgn ChrisPdgn marked this pull request as ready for review March 14, 2023 12:34
@kkopanidis kkopanidis merged commit d375f97 into storage-upload Mar 21, 2023
@kkopanidis kkopanidis deleted the storage-update-file branch March 21, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants