Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(database): SQL createView() already exists race condition #688

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

kon14
Copy link
Contributor

@kon14 kon14 commented Sep 21, 2023

This PR provides a workaround for concurrent createView() operations resulting in unique violation errors.
This issue only seems to be affecting the SQL adapter.
Initially investigated by @Renc17.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other (please describe)

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the PR's description (e.g. fix #xxx, where "xxx" is the issue number)

@ghost
Copy link

ghost commented Sep 21, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@kkopanidis kkopanidis merged commit e78cde4 into main Sep 21, 2023
4 checks passed
@kkopanidis kkopanidis deleted the sql-create-view branch September 21, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants