refactor(grpc-sdk): switch to full named exports for cjs compatibility #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(grpc-sdk, module-tools): applied replace transforms for lodash refactor: change all ConduitGrpcSdk imports
ChrisPdgn
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the "partial" compatibility of v0.16.6 in commonjs projects. Addressing 2 problems, 1. ConduitGrpcSdk not being a named export created issues with usage of the constructor. 2. Lodash required a conditional replacement, switching between lodash and lodash-es depending on output type.
Technically it's a breaking change as updating the grpc-sdk requires code changes. But, due to the ease of the changes and the fact that the core API does not introduce breaking changes, I flagged this as non breaking
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
The PR fulfills these requirements:
mainbranchfix #xxx, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: