Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(database): schema/extension creation timestamp field values mismatch #682

Merged
merged 3 commits into from
Sep 8, 2023

Conversation

kon14
Copy link
Contributor

@kon14 kon14 commented Sep 8, 2023

This PR resolves the following Database timestamps (createdAt, updatedAt) issues:

  1. SQL schema doc creation timestamp mismatch (create(), createMany())
  2. SQL/Mongo adapter operations explicitly setting timestamp field values regardless of modelOptions.timestamp
  3. Schema extension creation timestamps mismatch

In regards to [2]:
Sequelize completely ignored explicit query timestamp values.
Mongoose would use provided values, but doesn't really require setting them anyway.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other (please describe)

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the PR's description (e.g. fix #xxx, where "xxx" is the issue number)

@ghost
Copy link

ghost commented Sep 8, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@kkopanidis kkopanidis merged commit 1543e07 into main Sep 8, 2023
4 checks passed
@kkopanidis kkopanidis deleted the fix-timestamps branch September 8, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants