Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): socket pushes not working #82

Merged
merged 13 commits into from
Mar 28, 2022
Merged

fix(core): socket pushes not working #82

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
50d6586
fix(core): socket pushes not working
kkopanidis Mar 19, 2022
b2bbff1
chore(database): remove redundant async (#85)
kon14 Mar 21, 2022
f4cc8c2
fix(router, admin): Admin Swagger headers and route paths (#83)
kon14 Mar 21, 2022
a572921
chore(release): 0.12.3
kkopanidis Mar 21, 2022
6512912
chore: proper update of changelog
kkopanidis Mar 21, 2022
fc5b6ac
refactor(grpc-sdk): consistent routing functions
kkopanidis Mar 21, 2022
60e69e5
Makefile updates (v0.12.3) (#87)
kon14 Mar 22, 2022
59f171d
fix(router,admin): admin requests not passing through master key midd…
kon14 Mar 22, 2022
6a08cca
fix(router): excessive REST router refreshes (#90)
kon14 Mar 23, 2022
5557f5c
fix(router): socket push
kkopanidis Mar 24, 2022
c09db7b
fix(grpc-sdk): ParsedRouterRequest param type
kon14 Mar 24, 2022
e8fc2bc
Merge branch 'main' into socket-push-fix
kkopanidis Mar 25, 2022
bfd7f8b
refactor(grpc-sdk): cleanup router types
kkopanidis Mar 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions modules/chat/src/routes/routes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ export class ChatRoutes {
return 'Message updated successfully';
}

async connect(call: ParsedSocketRequest) {
async connect(call: ParsedSocketRequest): Promise<UnparsedSocketResponse> {
const { user } = call.request.context;
const rooms = await ChatRoom.getInstance()
.findMany({ participants: user._id });
Expand All @@ -299,7 +299,7 @@ export class ChatRoutes {

async onMessage(call: ParsedSocketRequest): Promise<UnparsedSocketResponse> {
const { user } = call.request.context;
const [roomId, message] = call.request.params;
const { roomId, message } = call.request.params;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be [ roomId, message ]. Socket params are an array.

const room = await ChatRoom.getInstance().findOne({ _id: roomId });

if (isNil(room) || !(room as ChatRoom).participants.includes(user._id)) {
Expand All @@ -323,7 +323,7 @@ export class ChatRoutes {

async onMessagesRead(call: ParsedSocketRequest): Promise<UnparsedSocketResponse> {
const { user } = call.request.context;
const [roomId] = call.request.params;
const { roomId } = call.request.params;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same ^

const room = await ChatRoom.getInstance()
.findOne({ _id: roomId });
if (isNil(room) || !(room as ChatRoom).participants.includes(user._id)) {
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.