fix(router, admin): Admin Swagger headers and route paths #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Admin's AuthMiddleware 'Authentication' header now prefixes its admin token with 'Bearer ' (previously 'JWT '). This change improves compatibility with OpenAPI and Swagger, while also improving consistency with user authentication. This is not a breaking change as backwards compatibility has been preserved.
… to shallow object copying
|
|
kon14
commented
Mar 21, 2022
| clientSecret: [], | ||
| }, | ||
| ], | ||
| security: JSON.parse(JSON.stringify(this._routerMetadata.globalSecurityHeaders)), |
There was a problem hiding this comment.
We could also entirely avoid repeated stringifications by just passing a pre-stringified globalSecurityHeaders instead. Totally type hacky, but definitely worth it perf-wise.
There was a problem hiding this comment.
Ended up stringifying once per Swagger construction instead (that makes 2 times total).
kkopanidis
approved these changes
Mar 21, 2022
kkopanidis
pushed a commit
that referenced
this pull request
Mar 24, 2022
* fix(router,admin): Admin Swagger using User headers * fix(router,admin): Admin Swagger routes not prefixed by '/admin' * chore(admin): Bearer prefix for admin Authentication header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #80 and generally improves Swagger route doc generation.
/admin/so that Swagger users no longer need to guess the proper baseUrl.This PR also converts Admin router's
Authenticationheader format fromJWT adminTokentoBearer adminToken.This change improves compatibility with OpenAPI and Swagger, while also improving consistency with user authentication.
This bit is not a breaking change as backwards compatibility has been preserved.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
mainbranchfix #xxx, where "xxx" is the issue number)