Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grpc-sdk): module connection not re-established after core shutdown #858

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

kkopanidis
Copy link
Contributor

@kkopanidis kkopanidis commented Dec 19, 2023

With the current implementation, should the core module shutdown, the modules do not attempt to reconnect to it. If they try to set config etc, they should re-establish connection but without properly updating their state. At the same time, the module change watcher won't be restarted and the module won't be made aware of any changes.

This PR fixes this issue, by making sure that once the core connection drops, the modules begin trying to reconnect, and restart the watchers upon successful connection.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other (please describe)

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the PR's description (e.g. fix #xxx, where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature

Other information:

@kkopanidis kkopanidis merged commit b7ce4b5 into main Dec 19, 2023
4 checks passed
@kkopanidis kkopanidis deleted the grpc-sdk/core-reconnect branch December 19, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants