fix(grpc-sdk): module connection not re-established after core shutdown #858
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current implementation, should the core module shutdown, the modules do not attempt to reconnect to it. If they try to set config etc, they should re-establish connection but without properly updating their state. At the same time, the module change watcher won't be restarted and the module won't be made aware of any changes.
This PR fixes this issue, by making sure that once the core connection drops, the modules begin trying to reconnect, and restart the watchers upon successful connection.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
The PR fulfills these requirements:
main
branchfix #xxx
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: