Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No logging on macOS #26

Closed
grakkpl opened this issue Feb 6, 2018 · 2 comments
Closed

No logging on macOS #26

grakkpl opened this issue Feb 6, 2018 · 2 comments

Comments

@grakkpl
Copy link

grakkpl commented Feb 6, 2018

Is there any chance you could fix logging on macOS? Is there any other way of getting the performance score (some avg fps)?

The-Forge/Common_3/OS/Logging/LogManager.cpp

Line 60 in ed732fc

#ifndef METAL // TODO: fix this

@grakkpl
Copy link
Author

grakkpl commented Feb 6, 2018

It also depends on #23 - without vsync off support (almost) all workloads are capped on ~16ms, even on low-end Mac

wolfgangfengel added a commit that referenced this issue May 3, 2018
@wolfgangfengel
Merge pull request #43 from ConfettiFX/confetti-dev
134472b 
## Release 1.08 - May 3rd, 2018 - The Forge in a DLL / New Vulkan Extension support / macOS/iOS clean up
 * We re-architected the rendering interface. If you use an older version, there are a lot of breaking changes in this update
   * replaced begin / endRender with cmdBindRendertargets
   * made the renderer compile into a DLL, so that you can have a Vulkan and a DirectX 12 DLL and switch between them during run-time. There is a new unit test showing this functionality. Removed more C++ constructs to make that happen
* DirectX 12: fixed bug in sampler comparison
* Vulkan (Windows and Linux): 
  * upgraded to Vulkan SDK 1.1.73.0 
  * added support for VK_EXT_descriptor_indexing and GL_EXT_nonuniform_qualifier
  * added support for NonUniformResourceIndex; in case it is supported it should be used now on Windows and Linux
  * fixed minimize bug
* macOS / iOS: 
  * updated to macOS 10.13.5 Beta (17F59b) / iOS 11.3.1 (15E302)
  * modified FileSystem so that macOS resembles the windows version in its behaviour
  * logging is working now on macOS / iOS: fixed issue #26 "No logging on macOS". To access iOS Logs after the application finished. Open the Devices and Simulator window in XCode and download the container for the app. The log can be found in the Contents of the container, in Appdata/Documents folder
  * Threads on macOS and iOS were not being joined on destruction, now they are
  * Building for macOS now only outputs errors and warnings, reducing the output to only the important info
* NuklearUI: added a new tree branch system to enable tabs in the future
@AntoineConffx
Copy link
Contributor

Closing this as logging has been enabled for both macOS and iOS in the latest Pull request: #43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@grakkpl @AntoineConffx @manas-kulkarni