If I understand your code correctly...

[chengchu88]

Hello sir,

In the file 'auxiliaries.py', line 391:

sample_idxs = np.random.choice(np.arange(len(gallery_feature_matrix_all)), n_image_samples)

If I understand your code correctly, should 'gallery_feature_matrix_all' be 'query_feature_matrix_all'?

Thanks

[Confusezius]

Hi there!

You are right! Going by meaning and to avoid errors on datasets with similar layout that are not the In-Shop dataset, it should be len(query_feature_matrix_all). I will adjust this.

However as a sidenote: This does not change any previously computed results, the numerical results are computed correctly (just checked again), and the qualitative results are still showing the closest gallery images given a query image, its just the random selection of query images to visualize that could change.

Thanks for pointing that out :).

[chengchu88]

Thanks for the confirmation. In my case the len(query_feature_matrix_all) is less than the len(gallery_feature_matrix_all), so I need to change it. Best, Cheng

…

On Thu, Sep 19, 2019 at 4:40 PM Karsten Roth ***@***.***> wrote: Hi there! You are right! Going by meaning and to avoid errors on datasets with similar layout that are not the In-Shop dataset, it should be len(query_feature_matrix_all). I will adjust this. However as a sidenote: This does not change any previously computed results, the numerical results are computed correctly (just checked again), and the qualitative results are still showing the closest gallery images given a query image, its just the random selection of query images to visualize that could change. Thanks for pointing that out :). — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3?email_source=notifications&email_token=AJKLC6CCW7CVOQ2B5KGBDJDQKQEYDA5CNFSM4IYRA2J2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7FD47Y#issuecomment-533347967>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AJKLC6D3YW4T7LPPP42NSHTQKQEYDANCNFSM4IYRA2JQ> .