Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TestParseReader compile error #89

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Fix TestParseReader compile error #89

merged 1 commit into from
Jan 9, 2023

Conversation

masumomo
Copy link
Contributor

@masumomo masumomo commented Jan 2, 2023 •
edited

Hi, thanks for making NATS by examples project. 馃槃 I'm going through this example to learn NATS!

I found the nbe's parseReader has compile error, so I fix it. 馃槈

bruth
bruth approved these changes Jan 9, 2023
View reviewed changes
Copy link
Collaborator

@bruth bruth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is mildly embarrassing 馃槃 All the CI is dedicated to validating the examples and building the binary, but not running the unit tests. Thanks! I will need to update it to run the tests as well..

@bruth bruth merged commit a1a3b4c into ConnectEverything:main Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruth bruth bruth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@masumomo @bruth