Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JS partition example #91

Merged
merged 9 commits into from
Jan 12, 2023
Merged

Add JS partition example #91

merged 9 commits into from
Jan 12, 2023

Conversation

bruth
Copy link
Collaborator

@bruth bruth commented Jan 11, 2023

No description provided.

Signed-off-by: Byron Ruth <byron@nats.io>
Signed-off-by: Byron Ruth <byron@nats.io>
Signed-off-by: Byron Ruth <byron@nats.io>
Signed-off-by: Byron Ruth <byron@nats.io>
Signed-off-by: Byron Ruth <byron@nats.io>
Signed-off-by: Byron Ruth <byron@nats.io>
@bruth bruth marked this pull request as ready for review January 11, 2023 17:09
the stream is replicated to the majority of servers having a
replica. On successful a publish, every replica of the stream
is guaranteed to have the same order of messages. Similiarly,
consumers on that stream will always receive the messages in
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notice that only 'Ordered' consumer guarantees ordered delivery.

Regular consumer may deliver out of order (although they don't in most cases).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood, I indicated the happy path. I chose not to talk about re-deliveries and concurrent subs bound to a stream. I can clarify to avoid claiming any guarantee if you prefer.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this example may not be the best place to have that kind of digression. Just wanted to highlight, but you know best what and what doesn't belong here.

Signed-off-by: Byron Ruth <byron@nats.io>
Signed-off-by: Byron Ruth <byron@nats.io>
Signed-off-by: Byron Ruth <byron@nats.io>
@bruth bruth merged commit 4987be7 into main Jan 12, 2023
@bruth bruth deleted the bench-partitions branch January 12, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants