Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charts open with Humidity selected and display 'Error: No data...' #11

Closed
BNNorman opened this issue Feb 20, 2019 · 7 comments
Closed
Labels
bug Something isn't working upstream It's over there

Comments

@BNNorman
Copy link

When I click on a device the chart defaults to trying to display Humidity which causes an error mesage to appear since most devices don't record Humidity. Clicking on a device which does record humidity is fine,

The dialog message, should be reworded to something like "No data has been recorded for this chart tab. Try clicking on another tab".

It isn't really an error message anyway - it's more of an information thing.
image

@sbrl
Copy link
Collaborator

sbrl commented Feb 21, 2019

Yep! This is because that sensor has apparently reported some humidity data in the past, which the system has picked up on. Said data probably needs cleaning out, as it's probably been assigned to the wrong device id by mistake by a previous iteration of the broker script.

@sbrl sbrl added bug Something isn't working feedback needed Further information is requested and removed feedback needed Further information is requested labels Feb 21, 2019
@bsimmo
Copy link
Member

bsimmo commented Feb 25, 2019

Could it default to PM2.5 (since that's the main target at the moment, then move to Temperature, then .. if not recent data)
or possibly look at most recent data and then decide ?

@bsimmo
Copy link
Member

bsimmo commented Feb 25, 2019

Actually this seems better now.
it is defaulting to PM2.5 though with robin05 with no PM sensor it errors at start.

@BNNorman
Copy link
Author

BNNorman commented Feb 25, 2019 via email

@sbrl
Copy link
Collaborator

sbrl commented Feb 25, 2019

@bsimmo Ah yes - I fixed a bug in which it was defaulting to the first item it found, which is humidity. It was left over from the schema update.

@sbrl sbrl added the upstream It's over there label Feb 25, 2019
@sbrl
Copy link
Collaborator

sbrl commented Mar 18, 2019

@BNNorman, can we close this now?

@BNNorman
Copy link
Author

Yes I think so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upstream It's over there
Projects
None yet
Development

No branches or pull requests

3 participants