Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added batch size to hibernate #552

Merged
merged 1 commit into from
Apr 10, 2018
Merged

added batch size to hibernate #552

merged 1 commit into from
Apr 10, 2018

Conversation

arya-hemanshu
Copy link
Contributor

Description

Currently DC doesn't have any minimum batch size limit, which means that every time database tries to save anything it creates a batch size of 5 records, which makes the saving operation slow.

This PR addresses that issue and puts a batch size of 50. Have tested this by running various recipes and they all showed performance improvements and were 3-4 times faster.

Checklist

  • Created new test(s) (if applicable)
  • Updated the README / documentation (if applicable)

Copy link
Contributor

@lorenaqendro lorenaqendro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@arya-hemanshu arya-hemanshu merged commit ca7f4dd into master Apr 10, 2018
@arya-hemanshu arya-hemanshu deleted the implement_batch_size branch April 10, 2018 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants