Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UBL-SR-51 does not check cac:DeliveryLocation #347

Closed
juskoljo opened this issue May 29, 2023 · 1 comment
Closed

UBL-SR-51 does not check cac:DeliveryLocation #347

juskoljo opened this issue May 29, 2023 · 1 comment
Milestone

Comments

@juskoljo
Copy link

Hi,

It seems that DeliveryLocation is not covered with the updated rule (v.1.3.10)

<cac:Delivery>
  <cbc:ActualDeliveryDate>2014-01-01</cbc:ActualDeliveryDate>
  <cac:DeliveryLocation>
    <cbc:ID schemeID="0088">1238764941386</cbc:ID>
    <cac:Address>
      <cbc:StreetName>StreetName</cbc:StreetName>
      <cbc:CityName>CityName</cbc:CityName>
      <cbc:PostalZone>1234</cbc:PostalZone>
      <cac:AddressLine>
        <cbc:Line>AddressLine/Line</cbc:Line>
      </cac:AddressLine>
      <cac:AddressLine>
        <cbc:Line>AddressLine/Line</cbc:Line>
      </cac:AddressLine>
      <cac:AddressLine>
        <cbc:Line>AddressLine/Line</cbc:Line>
      </cac:AddressLine>
      <cac:AddressLine>
        <cbc:Line>AddressLine/Line</cbc:Line>
      </cac:AddressLine>
      <cac:Country>
        <cbc:IdentificationCode listID="ISO3166-1:Alpha2">NO</cbc:IdentificationCode>
      </cac:Country>
    </cac:Address>
  </cac:DeliveryLocation>
</cac:Delivery>

Also I'm wondering why rule context has cac:RegistrationAddress and cac:DeliveryAddress as those are not part of EN16931 model? (https://test-docs.peppol.eu/poacc/billing/3.0/rules/ubl-tc434/)

<rule context="//cac:PostalAddress | //cac:RegistrationAddress | cac:DeliveryAddress">
  <assert id="UBL-SR-51" flag="fatal" test="not(cac:AddressLine) or count(cac:AddressLine) = 1">...</assert>
</rule>

With Best Regards,
Jussi

@oriol oriol added this to the 1.3.11 milestone Sep 27, 2023
@oriol
Copy link
Collaborator

oriol commented Sep 28, 2023

Thanks Jussi, changed the context for rule UBL-SR-51 to remove the ones not in the EN and adding the cac:Address from the DeliveryLocation.

@oriol oriol closed this as completed Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants