Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CII Missing check on DefinedTradeContact cardinality #354

Closed
AndreasPvd opened this issue Aug 2, 2023 · 1 comment
Closed

CII Missing check on DefinedTradeContact cardinality #354

AndreasPvd opened this issue Aug 2, 2023 · 1 comment
Milestone

Comments

@AndreasPvd
Copy link
Contributor

Hello all,

The EN16931 defines that BG-6 (Seller contact) and BG-9 (Buyer contact) have a cardinality of 0..1. UBL matches this definition as it only provides one contact per party. But CII supports multiple contacts (0..n).
The check to prevent the provision of multiple BG-6 and BG-9 is missing in the validation artefacts.

Between CII-SR-226 and CII-SR-227 there should be a rule added like
<param name="CII-SR-XXX" value="( count(ram:SellerTradeParty/ram:DefinedTradeContact) &lt;= 1)"/>

and between CII-SR-255 and CII-SR-256 there should be a rule added like
<param name="CII-SR-YYY" value="( count(ram:BuyerTradeParty/ram:DefinedTradeContact) &lt;= 1)"/>

and definitely the corresponding messages

<assert test="$CII-SR-XXX" flag="fatal" id="CII-SR-XXX">[CII-SR-XXX] - DefinedTradeContact of SellerTradeParty should exist maximum once</assert>
<assert test="$CII-SR-YYY" flag="fatal" id="CII-SR-YYY">[CII-SR-YYY] - DefinedTradeContact of BuyerTradeParty should exist maximum once</assert>

Br,
Andreas

@oriol oriol added this to the 1.3.11 milestone Sep 27, 2023
@oriol
Copy link
Collaborator

oriol commented Sep 28, 2023

Added rules CII-SR-455 and CII-SR-456

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants