-
Notifications
You must be signed in to change notification settings - Fork 38
Conversation
NOTE: Don't merge this PR without consolidating with #738 |
Blocked by #742 to support testing |
Hey, pedrouidWe noticed you made changes to a file with a TODO on it.
|
Requires #754 and it should have tests of itself too |
Hey, pedrouidIt looks like you made some changes to this pull request!
|
describe("Create Channel", () => { | ||
it("Happy case: user creates channel with mainnet network string", async () => { | ||
const clientA: IConnextClient = await createDefaultClient("mainnet"); | ||
expect(clientA.multisigAddress).to.be.ok; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should also add a test that if you instantiate the default client and a client with client opts you get the same multisig address
Allowing clients to be instantiated with default options using our hosted hub by passing a network string as either
rinkeby
ormainnet
(using mnemonic)Rinkeby
Mainnet