Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation declaration dropped by Firefox #6

Closed
octycs opened this issue Mar 25, 2015 · 5 comments
Closed

Animation declaration dropped by Firefox #6

octycs opened this issue Mar 25, 2015 · 5 comments

Comments

@octycs
Copy link
Contributor

octycs commented Mar 25, 2015

Firefox can't parse this (example):
animation: line-scale-pulse-out-rapid 0.9s 0 infinite cubic-bezier(.11,.49,.38,.78);

After changing it to
animation: line-scale-pulse-out-rapid 0.9s 0s infinite cubic-bezier(.11,.49,.38,.78);
it works.

@J3RN
Copy link

J3RN commented Mar 26, 2015

After seeing the demo, I came here to open this issue, and looks like you beat me to it! Let me know if you guys need any help with this.

@octycs
Copy link
Contributor Author

octycs commented Mar 26, 2015

Thanks for fixing, @mixxorz.

@octycs octycs closed this as completed Mar 26, 2015
@octycs
Copy link
Contributor Author

octycs commented Mar 26, 2015

Sorry, that was too early. Some animations still don't work:

  1. Firefox can't parse animation name in quotes:
    $animations: "ball-triangle-path-1" "ball-triangle-path-2" "ball-triangle-path-3";
    Instead it should be $animations: ball-triangle-path-1 ball-triangle-path-2 ball-triangle-path-3;
    2.animation-delay: 0; should be animation-delay: 0s;.

@octycs octycs reopened this Mar 26, 2015
@ConnorAtherton
Copy link
Owner

Ah, my bad. Do you want to fix this and just tell me when you think it is ready to be merged? The ball-triangle-trace animation seems to be the only one that isn't working correctly in firefox.

octycs added a commit to octycs/loaders.css that referenced this issue Mar 26, 2015
@octycs
Copy link
Contributor Author

octycs commented Mar 26, 2015

It's ready to be merged: #9 , but I have to correct myself:
You don't need to replace animation-delay: 0; because it is always overwritten.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants