Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Power saving mode #111

Merged
merged 8 commits into from Aug 18, 2022
Merged

Power saving mode #111

merged 8 commits into from Aug 18, 2022

Conversation

ScoreUnder
Copy link
Collaborator

I thought it would be fun to add a "power saving" mode where it doesn't draw the openGL canvas while it's not in use.

Do you like the idea? Does it work for you? Does it have any noticeable bugs vs default?

Caveats so far:

  • Switching workspaces and switching back gives it a blank preview (remedied by clicking on it)
  • There are quite a few things that need to hook into the framerate thing to request a frame

@ScoreUnder ScoreUnder marked this pull request as ready for review August 18, 2022 00:08
ConnorDY
ConnorDY previously approved these changes Aug 18, 2022
@ConnorDY ConnorDY added the enhancement Enhancement to existing feature(s) label Aug 18, 2022
CHANGELOG.md Show resolved Hide resolved
@@ -24,6 +24,7 @@ We recommend using the latest release unless you are having issues with it.
| `last-cache-dir` | `String` | Empty | The last cache that was used. |
| `last-checked-for-updates` | `Long` | `0` | The last time an update check was performed, in unix timestamp format. Used to limit the number of requests made to GitHub's servers. |
| `mouse-warping` | `Boolean` | Varies | If enabled, the mouse will warp from one edge to the other if it leaves the window while the camera is being dragged. Disabled by default on MacOS due to permissions requirements, enabled everywhere else. |
| `power-saving-mode` | `Boolean` | `false` | If enabled, will attempt to keep the idle frame rate as low as possible without impacting usability. |
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ScoreUnder ScoreUnder merged commit 795a709 into main Aug 18, 2022
@ScoreUnder ScoreUnder deleted the minimal-fps branch August 18, 2022 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to existing feature(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants