Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some unused variables #11

Merged
merged 2 commits into from
Oct 8, 2021
Merged

Remove some unused variables #11

merged 2 commits into from
Oct 8, 2021

Conversation

rajoriaakash
Copy link
Contributor

I tried to work down on Issue #9. Kindly review my PR. Thanks :)

Copy link
Collaborator

@m5x5 m5x5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one change needs to be undone, I committed one. Otherwise, it looks good. Thanks!

renderer/lib/runInContext.js Show resolved Hide resolved
@m5x5
Copy link
Collaborator

m5x5 commented Oct 7, 2021

It'd be nice if we could mark it as an exception somehow so that DeepSource won't make an issue out of it.

@m5x5 m5x5 changed the title Remove unused variables Remove some unused variables Oct 8, 2021
@m5x5 m5x5 merged commit 4fb4425 into ConnorFTW:main Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants