add link shortening option #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit gives jist the new ability to shorten gist URLs using GitHub's URL shortener, git.io. It adds two options on the command line (`-s` and `--shorten`). If the shortening step fails, or if git.io is down, jist will just return the normal, unshortened version.
|
Coolness. Can you throw in some tests? I'd be happy with either mocks or live hits to the URL, whichever you want to do. Might require a bit of refactoring to be easy to test. |
|
I don't normally do Ruby stuff, so let me know if the tests look ok. I also updated the Gemfile--I needed to install the "extensions" gem, otherwise the tests wouldn't run for me. |
|
Awesome, thanks for this! |
|
Yep, really nice feature. @mattn — can you confirm that this works on your proxy setup? |
|
It need bits fix to post to git.io 8e64022 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit gives jist the new ability to shorten gist URLs using GitHub's URL shortener, git.io. It adds two options on the command line (
-sand--shorten).If the shortening step fails, or if git.io is down, jist will just return the normal, unshortened version.