Fix undefined method `windows?' #112
Conversation
This fixes an incompatibility with current pry HEAD, which apparently retired Pry::Platform. I fear this fix by itself would again be incompatible with current pry *release* version. But I don't know enough about the respective releases processes, and which strategy you tend to prefer (set dependency to next pry release/```respond_to?```/etc.). Feel free to close and/or adapt as you see fit.
|
You can use Alternatively, don’t use this helper and write your own version of that method so you don’t have to rely on this API. Apologies for the mess. I believe the current HEAD API won’t change anymore. P.S. If I could undo time, I wouldn’t be introducing this helper at all since it’s trivial to write your own check. |
|
FWIW, I restored the method and it'll emit a warning. It'll be removed after next Pry release, though. |
|
We should get this merge and consider a minimum pry version dependency. @MatthiasWinkelmann, can you rebase to trigger a CI rerun? |
|
Actually I could trigger a rerun and it looks fine. I'll merge and figure out about versioning tomorrow or so. |
|
@ConradIrwin can you cut a new release from master? |
|
done! @vincentwoo @kyrylo I've made you both gem maintainers |
|
@ConradIrwin Great. I'll try to git tag to match your release as well. |
This fixes an incompatibility with current pry HEAD, which apparently retired Pry::Platform.
I fear this fix by itself would again be incompatible with current pry release version. But I don't know enough about the respective releases processes, and which strategy you tend to prefer (set dependency to next pry release/
respond_to?/etc.).Feel free to close and/or adapt as you see fit.