Support EventMachine 1.0.4+ or EventMachine-LE #1
Conversation
Since e4445e00c1c7c78d98b47b8c025631050bffb87f, regular EventMachine has supported attach_server and attach_socket_server. This change allows people to use this gem together with either EventMachine-LE or regular EventMachine, provided it's recent enough. Since rubygems has no way of expressing what we want to do in the Gemspec, this change adjusts the spec to express the requirement in human-readable words, and adds a load-time check to ensure whichever EventMachine is in use is able to support this extension.
|
This seems good to me. The requirements field is just plain text that users have to parse? It's probably fine to not explicitly depend on event machine, but it would be good to document the additional dependency in the readme's installation section. On a vague note, I've often wondered if there could be a package manager where dependencies are declared as 'interfaces' and gems as 'implementations' (one gem could implement many interfaces); which would avoid problems like this, though that would no doubt come with a host of other issues. |
|
Yep, Agreed to the README change - have pushed a proposed doc update. And also agreed on the dependency management thing; I'd love to have an |
Support EventMachine 1.0.4+ or EventMachine-LE
Vanilla EventMachine 1.0.4 and above now support
attach_server, so I think this gem should support it. Sadly, there's no good way in Rubygems specs to express a requirement on two different, and differently-versioned gems that do the ~same thing, so I believe this may be the next best thing /-:Hope this is good, happy to make revisions if not (: