Skip to content
This repository has been archived by the owner on Jan 21, 2022. It is now read-only.

Add ERC20 decimal field support #115

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add ERC20 decimal field support #115

wants to merge 4 commits into from

Conversation

wtzb
Copy link

@wtzb wtzb commented Oct 30, 2018

Resolves #114

@CLAassistant
Copy link

CLAassistant commented Oct 30, 2018

CLA assistant check
All committers have signed the CLA.

@raulk raulk self-requested a review October 30, 2018 21:46
Copy link
Contributor

@raulk raulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Could you maybe add a trivial test here? Could be as simple enhancing the existing tests to request the new field.

https://github.com/ConsenSys/ethql/blob/master/src/__tests__/erc20/erc20.test.ts

@wtzb
Copy link
Author

wtzb commented Nov 12, 2018 via email

@wtzb
Copy link
Author

wtzb commented Nov 12, 2018 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants