Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BlobSidecarsByRange] Verify sidecar before consuming next response chunk #6727

Closed
StefanBratanov opened this issue Jan 24, 2023 · 1 comment · Fixed by #7576
Closed

[BlobSidecarsByRange] Verify sidecar before consuming next response chunk #6727

StefanBratanov opened this issue Jan 24, 2023 · 1 comment · Fixed by #7576
Assignees
@zilm13
Labels
Epic Deneb Issues required to implement Deneb upgrade

Comments

@StefanBratanov
Copy link
Contributor

StefanBratanov commented Jan 24, 2023 •
edited
Loading

As per spec

Before consuming the next response chunk, the response reader SHOULD verify the blob sidecar is well-formatted and correct w.r.t. the expected KZG commitments through validate_blobs.
@StefanBratanov StefanBratanov added the Epic Deneb Issues required to implement Deneb upgrade label Jan 24, 2023
@StefanBratanov StefanBratanov mentioned this issue Jan 24, 2023
Closed
58 tasks
@StefanBratanov StefanBratanov changed the title [BlobsSidecarsByRange] Verify sidecar before consuming next response chunk [BlobSidecarsByRange] Verify sidecar before consuming next response chunk Feb 23, 2023
@StefanBratanov
Copy link
Contributor Author

Modified the issue to be aligned with the uncoupling spec

@StefanBratanov StefanBratanov mentioned this issue Feb 23, 2023
Closed
44 tasks
@zilm13 zilm13 self-assigned this Oct 3, 2023
@zilm13 zilm13 mentioned this issue Oct 4, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zilm13 zilm13

Labels
Epic Deneb Issues required to implement Deneb upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add BlobSidecarsByRangeListenerWrapper with BlobSidecar p2p verification zilm13/teku
2 participants
@zilm13 @StefanBratanov