Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure uses of LOG instance are not abbreviating keys #4865

Merged
merged 2 commits into from
Jan 16, 2022
Merged

Ensure uses of LOG instance are not abbreviating keys #4865

merged 2 commits into from
Jan 16, 2022

Conversation

courtneyeh
Copy link
Contributor

fixes #4843

Documentation

  • I thought about documentation and added the documentation label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

ajsutton
ajsutton approved these changes Jan 16, 2022
View reviewed changes
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@courtneyeh courtneyeh merged commit 0ba72b8 into Consensys:master Jan 16, 2022
@courtneyeh courtneyeh deleted the abbreviated-logs branch January 16, 2022 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajsutton ajsutton ajsutton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't abbreviate hashes/public keys in logs
2 participants
@courtneyeh @ajsutton