Merge pull request #175 from ConsenSys/download-compiler

Fix download compiler only once
Consensys · Apr 12, 2019 · d9a0ee7 · d9a0ee7
2 parents 530034f + d9fb142
commit d9a0ee7
Showing 1 changed file with 9 additions and 13 deletions.
diff --git a/compat/truffle-compile/index.js b/compat/truffle-compile/index.js
@@ -339,20 +339,16 @@ compile.with_dependencies = async function(options, callback, compileAll) {
 
   filteredRequired = filteredRequired.filter(sourcePath => !sourcePath.endsWith('/Migrations.sol'))
 
-  let isSolcLoaded = false;
+  if (filteredRequired.length > 0) {
+    // Download solc compiler
+    const supplier = new CompilerSupplier(options.compilers.solc);
+      await supplier.load()
+        .catch(e => {
+          throw e;
+        })
+
+  }
   Promise.all(filteredRequired.map(async (sourcePath) => {
-    if (!isSolcLoaded) {
-      const supplier = new CompilerSupplier(options.compilers.solc);
-      await supplier
-              .load()
-              .then(solc => {
-                // do nothing
-              })
-              .catch(e => {
-                throw e;
-              })
-      isSolcLoaded = true;
-    }
     await new Promise((resolve, reject) => {
       Profiler.imported_sources(
         config.with({