This repository has been archived by the owner on Jan 25, 2022. It is now read-only.
Fix download compiler only once #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbanmp
previously approved these changes
Apr 12, 2019
There was a problem hiding this comment.
Looks good to me.
I'm not sure if we handled this before, but an invalid compiler version will silently error and immediately quit. We can add an error message now, or we can create an issue and get back to that later, as its not too pressing.
━━┫ vim truffle-config.js # set solc to 0.6.100
━━┫ truffle run verify
<nothing>
━━┫ truffle compile
Error: Error: Could not find a compiler version matching 0.6.100. Please ensure you are specifying a valid version, constraint or build in the truffle config. Run `truffle compile --list` to see available versions.
at VersionRange.load (/home/nat/.nvm/versions/node/v11.10.0/lib/node_modules/truffle/build/webpack:/packages/truffle-compile/compilerSupplier/loadingStrategies/VersionRange.js:188:1)
at processTicksAndRejections (internal/process/next_tick.js:81:5)
Truffle v5.0.4 (core: 5.0.4)
Node v11.10.0
nbanmp
dismissed
their stale review
Actually... let me test this a bit more, something came up, I'm not sure it was introduced by this, but its very related to this. It happened when I was compiling the proxy contracts from the swc registry.
nbanmp
approved these changes
Apr 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.