Skip to content
This repository has been archived by the owner on Jan 25, 2022. It is now read-only.

Add an unadvertised --no-cache-lookup option... #75

Merged
merged 1 commit into from
Feb 21, 2019

Conversation

rocky
Copy link
Contributor

@rocky rocky commented Feb 21, 2019

Fix the eslint problem caused by introducing ...

@daniyarchambylov I would appreciate it if you would change the tests so that the are not so fragile when adding a parameter like noCacheLookup. Two problems

  1. adding a field breaks tests. (Fields are always going to be added and I don't want to keep updating tests when they do)
  2. You have to change something like 4 places because the same code appears. Please DRY (Do not repeat yourself)

Fix the eslint problem caused by introducing `...`
@rocky rocky merged commit 82400cc into master Feb 21, 2019
@rocky rocky deleted the add-no-cache-lookup-option branch March 1, 2019 19:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant