Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #525 Sorting sql files to be executed from V1,V2 to V10 and not from V10,V1 to V9 #526

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

mgarciate
Copy link
Contributor

Fixed #525

@CLAassistant
Copy link

CLAassistant commented Mar 4, 2022

CLA assistant check
All committers have signed the CLA.

@usmansaleem
Copy link
Contributor

@mgarciate thank you for the PR. Let me test it locally and we can merge it after that.

@usmansaleem usmansaleem self-assigned this Mar 8, 2022
@usmansaleem usmansaleem added TeamCerberus Under active development by TeamCerberus @Consensys and removed TeamCerberus Under active development by TeamCerberus @Consensys labels Mar 8, 2022
Copy link
Contributor

@usmansaleem usmansaleem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. See comments in the #525 for additional approaches as well.

@usmansaleem usmansaleem merged commit 222755c into Consensys:master Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error while installing slashing protection database v10
3 participants