Address all solidity compiler (solc) warnings.
#152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i.e. updated fxn signatures to not have return value if fxn didn't actually return anything.
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ |
|
I have read the CLA Document and I hereby sign the CLA |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Address all compile warnings that
solcprovides when compiling contracts.Motivation and Context
After forking repo & running
nvm use && yarn, we see a bunch ofsolccompiler warnings that as of now can't be disabled (see here & here). This presents a problem for developers who are using theUniversalToken/library because they have noisy outputs when compiling contracts; other important warnings/errors can be lost in the noise.How Has This Been Tested?
Ran
yarn coveragesuccessfully.Types of changes
Checklist: