Fix besu integration #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tests set the path to build/lib, in release set it to ./ because it is used on libbesu_native_ec.dylib and it will be always in the same folder as the crypto library Signed-off-by: Daniel Lehrner <daniel@io.builders>
Signed-off-by: Daniel Lehrner <daniel@io.builders>
daniel-iobuilders
force-pushed
the
fix_besu_integration
branch
from
f305e83
to
32b7d7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The path were MacOS is searching for libbesu_native_ec_crypto was not correct. In order to fix it the path is created using a variable prefix which has to be set to execute the tests and later to create the release build of libbesu_native_ec, which links to the crypto library.
Comments where added to Makefile as well.