This repository has been archived by the owner on Apr 5, 2024. It is now read-only.
[474] Add proxy options to http client to use Ethsigner behind proxy #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
usmansaleem
reviewed
Nov 10, 2022
|
|
||
| applyTlsOptions(clientOptions, config); | ||
| return clientOptions; | ||
| } | ||
|
|
||
| private static Optional<ProxyOptions> proxyOptions() { | ||
| var proxyHost = System.getProperty("http.proxyHost", "none"); | ||
| var proxyPort = Integer.valueOf(System.getProperty("http.proxyPort", "80")); |
There was a problem hiding this comment.
Integer.valueOf can throw NumberFormatException. catch block can be used to assign default value of 80 to proxy port.
There was a problem hiding this comment.
Ideally we should be able to cover all the options in ProxyOptions i.e. https://vertx.io/docs/apidocs/io/vertx/core/net/ProxyOptions.html . Specifying only host/port will work for unauthenticated proxy.
There was a problem hiding this comment.
Hello @usmansaleem, I added two commits to the PR
siladu
added
the
TeamGroot
jframe
reviewed
Nov 18, 2022
ethsigner/core/src/main/java/tech/pegasys/ethsigner/core/WebClientOptionsFactory.java
Outdated
Show resolved
Hide resolved
ethsigner/core/src/main/java/tech/pegasys/ethsigner/core/WebClientOptionsFactory.java
Outdated
Show resolved
Hide resolved
ethsigner/core/src/main/java/tech/pegasys/ethsigner/core/WebClientOptionsFactory.java
Outdated
Show resolved
Hide resolved
siladu
removed
the
TeamGroot
jframe
reviewed
Nov 21, 2022
ethsigner/commandline/src/main/java/tech/pegasys/ethsigner/EthSignerBaseCommand.java
Show resolved
Hide resolved
ethsigner/commandline/src/main/java/tech/pegasys/ethsigner/EthSignerBaseCommand.java
Outdated
Show resolved
Hide resolved
…rouped with the other downstream config.
jframe
added
the
doc-change-required
jframe
approved these changes
Nov 23, 2022
jframe
reviewed
Nov 23, 2022
usmansaleem
approved these changes
Nov 23, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Add configuration to the vertx http client used by Ethsigner to access blockchain node behind a proxy.
Fixed Issue(s)
fixes #474
Documentation
A change in the documentation should be made to use config variables for proxy :
--downstream-http-proxy-host : Hostname for proxy connect, no proxy if null (default: null)
--downstream-http-proxy-port : Port for proxy connect (default: 80)
--downstream-http-proxy-username : Username for proxy connect, no authentication if null (default: null)
--downstream-http-proxy-password : Password for proxy connect, no authentication if null (default: null)