Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw an error when inverse by 0 in BatchCompressTorus() #222

Merged
merged 3 commits into from
Jul 27, 2022
Merged

Throw an error when inverse by 0 in BatchCompressTorus() #222

merged 3 commits into from
Jul 27, 2022

Conversation

yelhousni
Copy link
Collaborator

No description provided.

@yelhousni yelhousni requested a review from gbotrel July 26, 2022 21:07
@gbotrel
Copy link
Collaborator

gbotrel commented Jul 27, 2022

So, do we explicitly say that batchInverse returns 0 for inv(0)?

@yelhousni
Copy link
Collaborator Author

if this gets merged we can keep inv(0)=0

@gbotrel
Copy link
Collaborator

gbotrel commented Jul 27, 2022

OK but we will need to document BatchInvert independently; since it's a public function it can be used in other places.

@gbotrel gbotrel merged commit 910b0ec into develop Jul 27, 2022
@gbotrel gbotrel deleted the fix/BatchCompressTorus branch July 27, 2022 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbotrel gbotrel Awaiting requested review from gbotrel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yelhousni @gbotrel