make mapToCurve public to allow for custom cofactor clearing
#372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This PR is against master. In general we base against develop first and then merge whole develop into master. Without knowing the context, was it intentional? |
Oh, sorry, wasn't intentional, do I base against develop then? |
|
Develop should be good! |
hussein-aitlahcen
force-pushed
the
public-maptocurve
branch
from
86feb5e
to
2da6b16
Compare
|
Updated! |
ivokub
approved these changes
Apr 25, 2023
p4u
pushed a commit
to vocdoni/gnark-crypto
that referenced
this pull request
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allow third party software to rely on the
mapToCurveprovided by gnark-crypto independently from the cofactor clearing.